alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project
https://alloy.rs
Apache License 2.0
653 stars 236 forks source link

Inline getters in impl of `Transaction` #1642

Closed emhane closed 1 week ago

emhane commented 1 week ago

Motivation

Avoid call overhead for transaction getters, also for compilation without LTO. Getters are expected to be hot paths with generalisation of data primitives in reth. To my understanding, that may make profiling rather cluttered and less meaningful (since releases are built with maxperf lto = fat).

Solution

Inline getters in impl of alloy_consensus::Transaction

PR Checklist

harunfox72s commented 6 days ago

@harunfox72..

https://github.com/BWS-fox