[Feature] Implement EIP-712 typed data signing for Trezor signer - Githubissues

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project

https://alloy.rs

Apache License 2.0

650 stars 231 forks source link

[Feature] Implement EIP-712 typed data signing for Trezor signer #201

Open DaniPopes opened 9 months ago

DaniPopes commented 9 months ago

Component

signers

Describe the feature you would like

This was never implemented in ethers-rs: https://github.com/gakonst/ethers-rs/blob/1354179f3c1586b1359c21a3a7e935edf1343ec8/ethers-signers/src/trezor/app.rs#L215-L221

Support could be added upstream to trezor_client

Additional context

EIP-712: https://eips.ethereum.org/EIPS/eip-712
@trezor/connect docs: https://docs.trezor.io/trezor-suite/packages/connect/methods/ethereumSignTypedData.html
trezor_client docs: https://docs.rs/trezor-client/latest/trezor_client/protos/messages_ethereum_eip712/index.html

royvardhan commented 2 months ago

Hey guys if this is still relevant, please assign it to me @DaniPopes @mattsse

zeroknots commented 2 months ago

yea this would be really cool go get