feat: rlp encoding for logs with generic event data

[prestwich]

closes #544

Motivation

Allow rlp encoding of logs after their data has been ABI decoded.

Solution

Add a set of methods and a blanket Encode implementation for Log<T> where for<'a> &'a T: Into<LogData>,

Note that this change does not allow decoding, as that would require embedding the ABI error into the RLP error decode impl

PR Checklist

• [x] Added Tests
• [ ] Added Documentation
• [ ] Breaking changes

[gakonst]

@Rjected ptal

[prestwich]

cc @DaniPopes what's up with the tests?

[DaniPopes]

You can update them by running with env TRYBUILD=overwrite, make sure to be on the latest nightly (and with -Zthreads=1 if you overwrite it)

[Rjected]

this also needs to be rebased

[prestwich]

clippy issue seems to have been introduced by merge of main. why?

Please do not merge until we know why this is the case

[Rjected]

clippy issue seems to have been introduced by merge of main. why?

Please do not merge until we know why this is the case

the new nightly clippy doesnt like things that are never constructed, including in tests

[onbjerg]

hmm unsure, was this struct ever used? doing

git grep "StructProp" (git rev-list --all)

yields nothing except changelog and the struct def itself

weird that it wouldn't be caught before this?

edit: not weird given dan comment

[prestwich]

the new nightly clippy doesnt like things that are never constructed, including in tests

why are we using nightly clippy? didnt we decide that was a mistake with ethers as it introduced unstable lints and situations like this where CI breaks for no reason?

[prestwich]

CI is unrelated.

[DaniPopes]

This breaks RLP encoding for Log<LogData> (the default). Fixed in #573.