Rearranged type param order so that the Network param is the last

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust

https://alloy.rs

Apache License 2.0

764 stars 139 forks source link

Rearranged type param order so that the Network param is the last #587

Closed moricho closed 5 months ago

moricho commented 5 months ago

Motivation

To default Network parameters to Ethereum in alloy-provider and alloy-contract, they need to be moved to the last of the type params: https://github.com/alloy-rs/alloy/pull/356 According to those changes, we need to adjust the type param order in sol! as well.

from: https://github.com/alloy-rs/alloy/issues/263

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

moricho commented 5 months ago

@onbjerg Thanks for your advice in https://github.com/alloy-rs/alloy/pull/356#issuecomment-2021855378. I've opened this PR to adjust the type param order in sol!

moricho commented 5 months ago

@mattsse

does this introduce more issues with patched alloy-core deps on alloy?

This PR will only affect alloy-contract and alloy-provider and it's already covered by the PR I created in alloy-rs/alloy. (sol! is being used only for tests in the packages for now)

moricho commented 5 months ago

@DaniPopes Thanks! I've just fixed https://github.com/alloy-rs/alloy/pull/356 and it's ready now. Once this PR is merged, I'll update alloy dependencies to use the latest alloy-core