search

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust
https://alloy.rs
Apache License 2.0
763 stars 137 forks source link

[Bug] Documentation isn't generating correctly for Signature #605

Closed kayabaNerve closed 2 months ago

kayabaNerve commented 5 months ago

Component

primitives

What version of Alloy are you on?

No response

Operating System

Other (please specify)

Describe the bug

Searching the documentation for "recover" does not show "Signature::recover", and there are other similarly missing items for Signature.

prestwich commented 3 months ago

I think this is related to this, which was included in rust 1.77.

cc @DaniPopes I am not sure why the docs.rs build would be on 1.80-nightly and still not be adding the appropriate impls here

prestwich commented 3 months ago

I have confirmed that local generation on 1.78 produces the impl blocks as expected

DaniPopes commented 3 months ago

I can see them only when passing --document-private-items, otherwise I get the same as docs.rs on both stable and nightly