search

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust
https://alloy.rs
Apache License 2.0
763 stars 137 forks source link

Add `SignatureError` variants #607

Closed tcoratger closed 5 months ago

tcoratger commented 5 months ago

Add SignatureError variants to address potential errors during conversion from a RPC transaction to a TransactionSignedEcRecovered.

Related: https://github.com/paradigmxyz/reth/pull/7752

DaniPopes commented 5 months ago

Sorry these don't belong here if the failure is in Reth code.

tcoratger commented 5 months ago

Add SignatureError variants to address potential errors during conversion from a RPC transaction to a TransactionSignedEcRecovered.

Related: paradigmxyz/reth#7752

Sorry, as this error variant https://github.com/alloy-rs/alloy/blob/c7a51e9b20e8d136572c30fc889799d97f50bd02/crates/rpc-types/src/eth/transaction/error.rs#L14 wraps a SignatureError, I was thinking this is a good place to add some signature related error variants. But understood, just provided the equivalent error variants directly inside ConversionError.