chore(general): add basic CI workflow for Windows - Githubissues

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust

https://alloy.rs

Apache License 2.0

763 stars 137 forks source link

chore(general): add basic CI workflow for Windows #613

Closed zerosnacks closed 4 months ago

zerosnacks commented 4 months ago

Motivation

Related PR in alloy: https://github.com/alloy-rs/alloy/pull/642 Continues from https://github.com/alloy-rs/core/pull/610

Solution

Implements windows-latest as test target whilst maintaining the current configuration.

For now disables the running of the abigen UI tests due to underlying differences in output not handled by trybuild

See run example: https://github.com/zerosnacks/core/actions/runs/8878272887

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

Notes

Reports build issues for: https://github.com/DaniPopes/keccak-asm/tree/master/sha3-asm on Windows MSVC as it is explictly not supported: https://github.com/DaniPopes/keccak-asm/tree/master?tab=readme-ov-file#support. It is expected the user enables or disables a feature depending on their needs and requirements rather than core offering an explicit fallback.