feat: Create new method on Param and EventParam - Githubissues

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust

https://alloy.rs

Apache License 2.0

763 stars 137 forks source link

feat: Create new method on Param and EventParam #634

Closed quentinv72 closed 3 months ago

quentinv72 commented 3 months ago

Motivation

Resolve https://github.com/alloy-rs/core/issues/240

Solution

Create a new method for Param and EventParam
Annotate the ty and name fields on Param and EventParam with #[doc(hidden)] to discourage users from creating their own isntances of those types wihtout using the new method. The reason for not making those fields private is that they are used by macros in different crates.

PR Checklist

[x] Added Tests
[x] Added Documentation
[ ] Breaking changes

prestwich commented 3 months ago

Thank you, I like this approach