Closed DaniPopes closed 2 months ago
What's a sensible default for no-op / testing then?
I think it'd be okay if default is always invalid
I would be very against this
why not just add a cfg_attr(test, derive(Default))
this only works internally I think
instead of proposing a feature, can you talk about the need? what are you trying to test?
dummy input to eth_signTypedData, currently I can only instatiate it from json or sol struct
sure but do you want input that's going to cause an error, GIGO, or something else?
if useful for testing we have used test-utils
features in the past instead of cfg_attr(test)
, and i'd be ok w it
cc @prestwich is this right or does this need a custom impl to handle resolver/..?