search

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust
https://alloy.rs
Apache License 2.0
758 stars 131 forks source link

Why redefine this mask function when ruint crate already have same mask function? #695

Closed rongyi closed 1 month ago

rongyi commented 1 month ago

https://github.com/alloy-rs/core/blob/adcf7adfa1f35c56e6331bab85b8c56d32a465f1/crates/primitives/src/signed/int.rs#L107

https://github.com/recmo/uint/blob/c4616bdb1bcdaa991ef23f9808c56c86127625ea/src/lib.rs#L321

mattsse commented 1 month ago

this is indeed duplicated and could be reused since it appears to be public ruint api