feat: add Signature trait

alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust

https://alloy.rs

Apache License 2.0

790 stars 155 forks source link

feat: add Signature trait #782

Open grandima opened 1 month ago

grandima commented 1 month ago

Motivation

Create trait Signature and move all possible methods and traits from struct Signature to trait Signature. Resolve #766

Solution

Add trait Signature.
Move all non-const functions totrait Signature.
Conform trait Signature to all possible supertraits.
Rename struct Signature into struct EcdsaSignature.

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

grandima commented 3 weeks ago

Hey @emhane! Thanks for your review. I'm still in progress on this ticket. To not take much of your time, I'll just trigger "Re-request review" when I'm ready with all the changes.

grandima commented 3 weeks ago

@emhane please review

grandima commented 2 weeks ago

I don't know exactly who from code owners to tag so I'll just pick @mattsse Please review.