Closed klkvr closed 3 weeks ago
Geth responds with v for EIP-1559 transactions. This PR updates default serde impl for PrimitiveSignature to accept v in place of yParity. Only 0/1 values for v would get correctly deserialized.
v
PrimitiveSignature
yParity
Additionaly, we now always serialize both v and yParity for compatibility as this is done in reth: https://github.com/paradigmxyz/reth/blob/bd8c4eceb20c39c6e501d06cf906469329340bb9/crates/rpc/rpc-types-compat/src/transaction/signature.rs#L29
Motivation
Geth responds with
v
for EIP-1559 transactions. This PR updates default serde impl forPrimitiveSignature
to acceptv
in place ofyParity
. Only 0/1 values for v would get correctly deserialized.Additionaly, we now always serialize both
v
andyParity
for compatibility as this is done in reth: https://github.com/paradigmxyz/reth/blob/bd8c4eceb20c39c6e501d06cf906469329340bb9/crates/rpc/rpc-types-compat/src/transaction/signature.rs#L29Solution
PR Checklist