search

alloy / lowdown

A Ruby client for the HTTP/2 version of the Apple Push Notification Service.
MIT License
120 stars 15 forks source link

Simplify threading #2

Closed alloy closed 8 years ago

alloy commented 8 years ago

@dblock @joeyAghion FYI

This PR removes the functionality to call callbacks onto the caller thread (e.g. main thread), instead it has a dedicated background thread where these callbacks are performed. Previously the user would have to know to call Connection#flush in order to actually perform the callbacks, which just felt fragile and required some additional complexity in this lib. Now the complexity is reduced to a more traditional producer-consumer version and it’s the user’s responsibility to deal with processing responses from a different thread.

In our case this means that updating notification documents in the DB will be performed from a different thread. From some reading-up on Mongoid, it appears that Mongoid will automatically create a new session for different threads and seeing as Sidekiq runs on threads, I assume that this is already working fine?

dblock commented 8 years ago

This is good. The next step is to get rid of all the threading and queuing code. You should replace it with something like EventMachine or Celluloid.