search

alloy / macvim

MacVim with file browser
https://github.com/alloy/macvim/wiki
599 stars 37 forks source link

Window doesn't close #21

Closed b4winckler closed 13 years ago

b4winckler commented 13 years ago

Trying to close a window results in results in

*** -[NSURL initFileURLWithPath:]: nil string parameter

being logged and the window never closes.

alloy commented 13 years ago

Fixed in b1ba22d1fc7173a54728f23692d7e851d96de69e

b4winckler commented 13 years ago

I forgot to thank you for fixing this so quickly. :-)

alloy commented 13 years ago

Oh, no problem, it was a simple fix :) But it’s good that you remind me, because I’m thinking we could now remove the BOOL ivar and simply check if the fileBrowser ivar isn't nil.

b4winckler commented 13 years ago

Ah yes, I was going to suggest that too but forgot. :-)

You may as well inherit from NSObject instead of NSViewController as well since none of the NSViewController features are really being used, but I guess that is a rather minor point...

alloy commented 13 years ago

And I forget it again :) Regarding inheriting from NSObject instead of NSViewController, there aren’t many features to begin with, I see it more as a hint of what kind of class it is.