First PR Attempt - Githubissues

nashadroid commented 5 years ago

PLEASE REVIEW THIS CAREFULLY! This is my first pull request for Allpix Squared, so if I've done anything wrong, please let me know and I will do my best to correct it :)

Cheers, Nashad

simonspa commented 5 years ago

Dear @nashadroid

thank you very much for your pull request, it looks very nice! There are only two things I would like you to address before merging:

Please add your name and current affiliation to the alphabetical author list here
Something to discuss: most *nix tools use the following guidelines for their command line options:
- Single dash followed by single letter: -l or -d
- Double dash followed by full word/name etc: --version or --gaussian
Do you think it would make sense to follow this convention also for this small Python tool?

For reference, I have opened a merge request on the main repository to check that the CI pipeline finishes successfully: https://gitlab.cern.ch/allpix-squared/allpix-squared/merge_requests/228

Cheers, Simon

nashadroid commented 5 years ago

@simonspa ,

Thank you for wanting to including me on the authors list!

I have just made the changes, what do you think?

Nashad

simonspa commented 5 years ago

Perfect, thank you @nashadroid!

(And that you're on the author list is just right - because you are one. :))

allpix-squared / allpix-squared

First PR Attempt #6