search

alltheatreides / AVE_MARIA_CK3

AVE MARIA mod for Crusader Kings 3 (CK3)
15 stars 7 forks source link

Update titles_l_english.yml #12

Closed Conchodebar closed 3 years ago

Conchodebar commented 3 years ago

Added all titles I could find. I haven't finished the catholic church titles as these don't seem ready yet.

Th3Nunnc3l3r commented 3 years ago

Looks good, but c_asciano has no caps in the localisation. Push a commit to this branch fixing it and I'll merge it unless Atreides says no. There's no overwrites so I don't see any risk.

alltheatreides commented 3 years ago

Did you use the vanilla 1.3 loc file ? It seems that some of the vanilla 1.3 title locs are not in your version. image

Do not worry though, I can easily copy paste the title you added, thanks :)

Conchodebar commented 3 years ago

I used the version from the master branch, is that not correct? I'm still learning how to use github so excuse my ignorance

alltheatreides commented 3 years ago

I used the version from the master branch, is that not correct? I'm still learning how to use github so excuse my ignorance

Ah nevermind you are right, I forgot about me adding that loc file, and the weird fact that github does not detect conflict fooled me, sorry !

Th3Nunnc3l3r commented 3 years ago

Shall we merge it then?