alltheplaces / alltheplaces

A set of spiders and scrapers to extract location information from places that post their location on the internet.
https://www.alltheplaces.xyz
Other
611 stars 205 forks source link

hyatt seems to miss POI type info #9399

Open matkoniecz opened 1 month ago

matkoniecz commented 1 month ago

https://github.com/alltheplaces/alltheplaces/blob/master/locations/spiders/hyatt.py

entries like

{
    'type': 'Feature',
    'id': '0INCt8SjzFq_enCSMaBNeVIyTYA=',
    'properties': {
        'ref': 'hyatt-place_en-US_yxszp-hyatt-place-prince-george',
        '@source_uri': 'https://www.hyatt.com/hyatt-place/en-US/yxszp-hyatt-place-prince-george',
        '@spider': 'hyatt',
        'addr:full': '585 Dominion Street',
        'addr:city': 'Prince George',
        'addr:state': 'BC',
        'addr:postcode': 'V2L 1T7',
        'addr:country': 'CA',
        'name': 'Hyatt Place Prince George',
        'phone': '+236 423 3324',
        'website': 'https://www.hyatt.com/hyatt-place/en-US/yxszp-hyatt-place-prince-george',
        'brand': 'Hyatt',
        'brand:wikidata': 'Q1425063'
    },
    'geometry': {'type': 'Point', 'coordinates': [-122.745712, 53.915016]}
}

seem typical

note that it is not really stated what it is

CloCkWeRX commented 1 month ago

https://github.com/alltheplaces/alltheplaces/blob/3b1c9f0b08aacfc6dabdd818949019b1de7d7b63/locations/spiders/hyatt.py#L10 Maybe just needs amenity hotel?

matkoniecz commented 1 month ago

Yeah, maybe tourism=hotel applies to all - though maybe they operate also other things? Why type was not picked from NSI?

impiaaa commented 1 month ago

The NSI matcher doesn't work when a (QID, region, category) refers to more than one preset. Hyatt has four.

matkoniecz commented 1 month ago

I guess it could be made smarter and take shared items

in this case brand has different values and tourism=hotel is shared