search

allthingslinux / tux

Tux is an all in one bot for the All Things Linux discord server.
https://discord.gg/linux
GNU General Public License v3.0
85 stars 26 forks source link

[BUG] - Forwarding messages bypasses GIF rate limit check #650

Open amadalusia opened 3 weeks ago

amadalusia commented 3 weeks ago

Describe the Bug

Discord has a feature where you can get messages from a host discord channel (say #lobby in SM64 Speedrunning) and then post it to the target discord server (say #general in All Things Linux), you can see an example of this in this message I sent a few days ago. This feature also allows for Tux's GIF rate limit feature to be bypassed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any chat with Tux where he is configured to have a GIF ratelimit
  2. Send a GIF
  3. Go to another server and send the same GIF regardless of which chatroom
  4. Forward that GIF to the chat with the rate limit
  5. You will see that you have posted 2 GIF's in a row where one is forwarded

image

Expected Behavior

Tux should be able to see the contents of the message and then realise there was 2 GIF's posted at the same time, removing the message automatically as a result of that action.

Environment (please complete the following information)

Skipping this information because this was tested on the production instance of the bot.

Additional Context

Asking an eye-witness senior mod to add context

FarCotton commented 3 weeks ago

Log of our conversation about the matter in Ticket #1655:

Ticket 1655 .txt