search

alltogethernow / web

Together web client
https://alltogethernow.io
MIT License
25 stars 2 forks source link

Error displaying feed items with category containing h-card #13

Closed jackjamieson2 closed 5 years ago

jackjamieson2 commented 5 years ago

Describe the bug When a feed item has a category with type=='card', Together won't render the parent channel at all.

Together returns an error Expected Iterable, but did not find one for field Post.category. for each item with that condition.

Documented with an example at https://github.com/jackjamieson2/yarns-microsub-server/issues/89

To Reproduce Steps to reproduce the behavior:

Using granary, convert a twitter feed into HTML. Add the resulting feed to a channel in Yarns Microsub Server. Attempt to view the channel in Together

Expected Behavior Either display the h-card as a category on the feed item, or if that's not possible display the feed item with this category removed.

Browser(please complete the following information): Not browser dependent.

More Info

If necessary, I can add a special case in Yarns which will filter out categories with type=='card'. I've tested this and it seems to fix the issue. But I think a more robust solution would be if Together would fail more gracefully.

jackjamieson2 commented 5 years ago

Some additional context from #indieweb-dev: https://chat.indieweb.org/dev/2019-08-13#t1565708318916100

jackjamieson2 commented 5 years ago

Based on further discussion in IRC, there are suggestions that this should be handled by the Microsub server since the client is expecting jf2.

My sense is that:

  1. I should make sure that Yarns' output is structured as correct jf2.
  2. It would still be nice if Together could fail more gracefully, but I understand that may be a challenge