Closed lararojasmr closed 1 year ago
I need to create a new fork and pull request because I didn't sign my commits. Thanks!
@eroshenkoam please could you help me with this PR? Thanks!
Hi @baev, thanks to execute the required build but, it's failing when it try to download a dependency. I am not able to reproduce that issue on my machine, I can generate a jar properly, using atlas-package after doing atlas-clean.
The bin that I generated: https://drive.google.com/file/d/1SyylGaE5-ZovT18NJ5KwJ55gS63qWUBp/view?usp=sharing
Command used: atlas-package
@lararojasmr hello sir, thanks a lot for your efforts. We've added the review of your PR to the plans and started executing the review/.
@lararojasmr Manuel, could you please check your email?
@lararojasmr Manuel, could you please check your email?
Thanks @cheshi-mantu. I'll make these changes, sorry I have been with a lot of work these days.
@lararojasmr Hi Manuel, have you had a chance to review? thanks
Yes, but let me make all the changes that you suggested. I have had a lot of work in the past months, so I haven't had the chance to make it. But, before 2023, I hope to have all changes done. Thanks! Ing. Manuel Lara LinkedIn: https://ve.linkedin.com/in/ingmanuellara
El jue, 24 nov 2022 a la(s) 09:44, Egor Ivanov @.***) escribió:
@lararojasmr https://github.com/lararojasmr Hi Manuel, have you had a chance to review? thanks
— Reply to this email directly, view it on GitHub https://github.com/allure-framework/allure-bamboo/pull/270#issuecomment-1326474148, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUAQ4J7SXRV7G7JXCWUJLDWJ5WLFANCNFSM57BYZ4ZA . You are receiving this because you were mentioned.Message ID: @.***>
Hi, I'm working to fix all your comments. Sorry for the delay!
@cheshi-mantu it's ready to merge!
@vbragin have you had a chance the updates?
This PR is a big refactor for all plugin it's fully tested in a bamboo evaluation environment and offer complete compatibility with the new API. Several bugs were solved in this version, and it's not compatible with the last release so I propose version 2.0.
The logo is customizable, the Allure Report Title is set by the plugin, and the report is exportable to a zip file. The history is generated properly, and the historical links work fine. Those are some of the changes that I made.
Details in commits details.