allure-framework / allure-bamboo

Allure plugin for Atlassian Bamboo
Apache License 2.0
26 stars 20 forks source link

Removed 1 unnecessary stubbing in AllureExecutableProviderTest.java #313

Closed ARUS2023 closed 8 months ago

ARUS2023 commented 9 months ago

In our analysis of the project, we observed that the stubbing which stubbed downloadAndExtractAllureTo is created in AllureExecutableProviderTest.setUp, but is never executed by 2 tests: AllureExecutableProviderTest.itShouldProvideExecutableForUnix and AllureExecutableProviderTest.itShouldProvideExecutableForWindows.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.