allure-framework / allure-csharp

Allure integrations for C# test frameworks
https://allurereport.org/
Apache License 2.0
104 stars 65 forks source link

Edit and continue does not work due to usage of AspectInjector 2.6 #304

Open andrematosfundao opened 1 year ago

andrematosfundao commented 1 year ago

I'm submitting a ...

What is the current behavior?

Cannot use edit and continue on debug mode when allureStepAttribute is used

see this video of the failure

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

in the code bellow put a break point on the test run in debug mode edit the string continue execution it fails

code example

What is the expected behavior?

we should be able to use edit and continue since it is such a great tool for development

What is the motivation / use case for changing the behavior?

making edit and continue work as expected.

Please tell us about your environment:

<TargetFramework>net7.0</TargetFramework>

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
<PackageReference Include="NUnit.Analyzers" Version="3.3.0" />
<PackageReference Include="NUnit.Allure" Version="1.2.1.1" />

Other information

I believe to fix this it is only necessary to update to AspectInjector 2.7

as a temporary fix i copied the code for AllureStepAttribute in my project and use the latest aspectInjector and that works for me.

neparij commented 1 year ago

@andrematosfundao Hi! Yes, this is known issue https://github.com/pamidur/aspect-injector/issues/138 I'll bump AspectInjector version in next release! Thanks!

neparij commented 1 year ago

Hello everyone! You can try it out in 2.9.3-preview.1 release

andrematosfundao commented 1 year ago

hello there @neparij, i updated to the 2.9.3-preview.1 version and i see the same problem, when allurestep is used edit and continue stops working: image

andrematosfundao commented 9 months ago

hello there, just to mention this is still a issue on 2.10 image