search

allure-framework / allure-js-commons

Deprecated, use https://github.com/allure-framework/allure-js instead
Other
27 stars 40 forks source link

Fix for using steps in beforeAll #30

Closed cakeinpanic closed 7 years ago

cakeinpanic commented 7 years ago

i've met an issue while using allure in my e2e tests: https://github.com/allure-framework/allure-jasmine/issues/30

fixed it with this PR also

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

just-boris commented 7 years ago

Thank you for your pull-request!

But, this is not the right way to solve the mentioned issue. This repository contains core for all Javascript frameworks we support now or will support in future. This is why the code here should be very much simple and straightforward.

For instance, we expect every derived reporter to call our methods in the right order. If there can be problems, it should be solved on frameworks' side, not here. Otherwise, it would be very hard to test the effect of that change.

just-boris commented 7 years ago

I could not find a better solution for the mentioned allure-jasmine issue, so let's merge this change. I have left couple comments that have to be fixed before.

cakeinpanic commented 7 years ago

Also edited changelog.md according to the fact that new version would be 1.3.1 If you think it should be 1.4.0, please, update it

cakeinpanic commented 7 years ago

and when merged, could you please also bump version of allure-js-commons in https://github.com/allure-framework/allure-jasmine

just-boris commented 7 years ago

Thank you!

Making release of Jasmine adapter will take some time, because it currently uses ~1 year old version of js-commons. Need to check what's up with the package.