search

allure-framework / allure-js-commons

Deprecated, use https://github.com/allure-framework/allure-js instead
Other
27 stars 40 forks source link

Fix timestamp issue #35

Closed potapovDim closed 6 years ago

potapovDim commented 6 years ago

https://github.com/allure-framework/allure-mocha/issues/44

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

just-boris commented 6 years ago

allure-js-commons package supposed to be very simple and lightweight. We expect, that package consumers provide data in already correct format and there is no need to do extra ckecks.

If you have more information how to reproduce the above mentioned issue, please share them there.

potapovDim commented 6 years ago

@just-boris end step was used like this reporter.endStep('broken', `${Date.now()} time` )

just-boris commented 6 years ago

It is not the expected use case, that we considered.

The signature of the method is strict endStep(status: string, timestamp: number).

What kind of use case do you have? Why could not prepare the number timestamp at your side?

potapovDim commented 6 years ago

@just-boris it was our fail, this pr was created as protection from a case like this because we spend some time before an error was found in a code

just-boris commented 6 years ago

For the upcoming version there will be Typescript definitions that you can use to ensure that proper values are provided. But there are no actions for now.