search

allure-framework / allure-js-commons

Deprecated, use https://github.com/allure-framework/allure-js instead
Other
27 stars 40 forks source link

Missed types #37

Closed zaqqaz closed 6 years ago

zaqqaz commented 6 years ago

it's just FYI :)

As types definitions are missed for this project, I implemented them by myself PR on review now https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25942

just-boris commented 6 years ago

Good to hear that!

How are you going to use them in the project? Allure injects API as a global object, so you will need to declare ambient variable in any way. See the issue: https://github.com/allure-framework/allure-jasmine/issues/21

zaqqaz commented 6 years ago

@just-boris Allure injects API it depends how you implement that. Allure itself its just a class. Which we create in the libary (it will jest-allure) and in the libary we have declare var allure: Allure; as it's libary create global allure object, not allure-js-commons itself.

just-boris commented 6 years ago

ok, I see you point. This totally should work fine.

Good luck you implementing this!

zaqqaz commented 6 years ago

@just-boris now you can check it here https://github.com/zaqqaz/jest-allure