search

allure-framework / allure-js-commons

Deprecated, use https://github.com/allure-framework/allure-js instead
Other
27 stars 40 forks source link

TypeError: allureJsCommons.AllureConfig is not a constructor #48

Closed vinceis1337 closed 3 years ago

vinceis1337 commented 3 years ago

Version 2.0.0.beta-11 has a backwards incompatibility issue because it removes these lines from index.js:

var AllureConfig_1 = require("./src/AllureConfig");
Object.defineProperty(exports, "AllureConfig", { enumerable: true, get: function () { return AllureConfig_1.AllureConfig; } });

This causes this issue: https://github.com/isaaceindhoven/testcafe-reporter-allure/issues/102 because it is a dependency for that framework.

mrtnvh commented 3 years ago

Hi @vinceis1337, I think this project is deprecated and moved to https://github.com/allure-framework/allure-js

There I found the PR that stated the removal of the AllureConfig class. https://github.com/allure-framework/allure-js/pull/323/files

The AllureConfig was marked as deprecated for a while, but we failed to notice this. So we as dependant of the allure-js-commons are IMO obliged to follow. I created a new issue on our side to follow up on this.

I think this issue can be closed.

Thank you for your help!

vinceis1337 commented 3 years ago

@vanhoofmaarten Thanks for the info! I'll close the issue.