allure-framework / allure-kotlin

Allure integrations for test frameworks targeting Kotlin and Java with 1.6 source compatibility.
Apache License 2.0
57 stars 21 forks source link

Allure Android implementation #19

Closed kamildziadek closed 4 years ago

kamildziadek commented 4 years ago

New allure android implementation. All of the features of the original allure-android were migrated, with small changes that make the API more robust.

Content:

Note: PR with sample usage and support for the updated target API to follow`

kamildziadek commented 4 years ago

This PR was made using minSdk 21 & targetSdk 28. I am resolving the issues with the compatibility to minSdk 15

kamildziadek commented 4 years ago

This PR was made using minSdk 21 & targetSdk 28. I am resolving the issues with the compatibility to minSdk 15

Compatibility issues resolved.

I just want to flag a couple of issues:

Considering this, I would say that it's worth increasing the min API to at least API 18 (98.4% of devices). This will help minimize the unexpected issues and make the road easier moving forward. The perfect solution would be to raise it up to API 21 (94.1% of users) as it's very stable API and I am quite confident all of the features work fine on this version.

What do you think about that @Badya, @viclovsky

viclovsky commented 4 years ago

This PR was made using minSdk 21 & targetSdk 28. I am resolving the issues with the compatibility to minSdk 15

Compatibility issues resolved.

I just want to flag a couple of issues:

* We can't easily test it on API 15 as the image is no longer available for download in Android Studio

* I have noticed some runtime issues on older APIs that require further investigation

* All of the rules are only working since API 18, as they require the usage of **ui-automator** (safety checks & documentation has been put in place, but the rules may be a bit confusing the library users).

Considering this, I would say that it's worth increasing the min API to at least API 18 (98.4% of devices). This will help minimize the unexpected issues and make the road easier moving forward. The perfect solution would be to raise it up to API 21 (94.1% of users) as it's very stable API and I am quite confident all of the features work fine on this version.

What do you think about that @Badya, @viclovsky

I have talked with other guys who uses allure-android library and we think that increasing the version won't be a big problem: most of the users has already increase the version. If user really need old version — it is possible to use old version of allure-android. Therefore, let's up the version smoothly: up to 18th (21th might be in future, when it will be necessary, for instance, on migrating to 29th API target version )