search

allure-framework / allure-php-api

PHP API for Allure Framework
Apache License 2.0
33 stars 28 forks source link

Changed repository name will make all Magento 2 projects fail upon composer install #76

Closed miloszowi closed 3 years ago

miloszowi commented 3 years ago

According to this commit repository name has been changed.

Current magento 2 core uses allure-framework/allure-php-commons as source to allure-framework/allure-php-api module and that will lead to crash every application that stands on Magento 2.

willbrammer commented 3 years ago

We are facing the same issue due to this change

mamsincl commented 3 years ago

image

composer update allure-framework/allure-php-api

this will refresh the repository URL in composer lock and the project will be installable again

as the module installed thru dependency chain by magento/magento2-functional-testing-framework, removing the framework from main composer.json also can work

composer remove magento/magento2-functional-testing-framework --update-with-dependencies

miloszowi commented 3 years ago

@mamsincl

Treat this thread as an information, as I already resolved the issue.

Making such a change without any warning before is not acceptable and should be avoided.

rayat commented 3 years ago

Hi Guys

"composer update allure-framework/allure-php-api" didn't work for me so I tried changing the git and dist URLs manually in composer.lock file.

If anyone is stuck with this error and need a quick fix, try this: Replace "commons" with "api" in URLs in composer.lock file:

Original text:

"name": "allure-framework/allure-php-api",
"version": "1.1.8",
"source": {
    "type": "git",
    "url": "https://github.com/allure-framework/allure-php-commons.git",
    "reference": "5ae2deac1c7e1b992cfa572167370de45bdd346d"
},
"dist": {
    "type": "zip",
    "url": "https://api.github.com/repos/allure-framework/allure-php-commons/zipball/5ae2deac1c7e1b992cfa572167370de45bdd346d",
    "reference": "5ae2deac1c7e1b992cfa572167370de45bdd346d",
    "shasum": ""
},

Replaced text:

"name": "allure-framework/allure-php-api",
"version": "1.1.8",
"source": {
    "type": "git",
    "url": "https://github.com/allure-framework/allure-php-api.git",
    "reference": "5ae2deac1c7e1b992cfa572167370de45bdd346d"
},
"dist": {
    "type": "zip",
    "url": "https://api.github.com/repos/allure-framework/allure-php-api/zipball/5ae2deac1c7e1b992cfa572167370de45bdd346d",
    "reference": "5ae2deac1c7e1b992cfa572167370de45bdd346d",
    "shasum": ""
},
baev commented 3 years ago

the problem is fixed.

So, a bit of clarification on what's happened and why.

Our team is working on a new major version of PHP integration. 1) Allure 2 model 2) All the new features, introduced in Allure 2 will be supported 3) Package & copyright changes (from Yandex namespace to Qameta) 4) Support for Allure TestOps features and more

In order to align module names with the rest of the languages and frameworks, we decide to rename the module from allure-php-api to allure-php-commons for a new version. And the only way to change the module name - is to create a new one.

So we decided to rename the current repository to allure-php-api (alignment with module name) and create a new repository allure-php-commons for a new version.

By default, renaming repositories isn't break everything as Github will create a redirect from old repository location to a new one. But we created a new allure-php-commons repo that overwrote the redirects that cause such problems.

So, I temporarily moved allure-php-commons repository to https://github.com/allure-framework/allure-php-commons2 ( it should not be a problem before we finish the work and release it ) and created redirects from https://github.com/allure-framework/allure-php-commons to https://github.com/allure-framework/allure-php-api. So we are good for now