search

allusion-app / Allusion

A free and open source desktop application for managing your visual library
GNU General Public License v3.0
698 stars 47 forks source link

WIP: Use 'sharp' for thumbnail generation #577

Open apage43 opened 1 year ago

apage43 commented 1 year ago

This is mostly to fix https://github.com/allusion-app/Allusion/issues/448 but also speeds thumbnail generation up quite a bit - I know this was tried before and ran into build issues.

I looked for instances of sharp and electron-build showing up in the same package.json to crib a workaround from - specifically I lifted from https://github.com/bitfocus/companion/blob/master/package.json - I'm not particularly familiar with node or Electron, and I suspect this doesn't yet fully work on Linux and Mac, but I'm likely to run this local fork indefinitely if no other fix for the crash issue lands so I figured I'd post the progress I'd made on it.

RvanderLaan commented 1 year ago

Awesome, thanks for taking the time to dive into this! That setup from the Companion repo seems to be cross-platform, I'll try to find some time soon to see if it's compatible on my Linux machine too