search

allusive-dev / compfy

A Compositor for X11 based on Picom. No Longer Maintained in favor of Picom v12!
203 stars 23 forks source link

Rounded corners are black on most windows #18

Closed ixion396 closed 10 months ago

ixion396 commented 10 months ago

On some windows, the rounded corners work perfectly. However, most windows (kitty, electron-based, gtk, qt, etc...) have rounded corners that are filled in. Note that changing detect-rounded-corners does not fix it.

ixion396 commented 10 months ago

I am using standard i3 with no patches.

allusive-dev commented 10 months ago

Hello @nousername33 What version of the package are you using and how did you install it?

ixion396 commented 10 months ago

Hi, thanks for answering so quickly! I am using 1.2.3-1 and I got it from the AUR.

allusive-dev commented 10 months ago

Ok. I have a guess what the issue is. v1.2.3 fixed an issue on AwesomeWM where rounded corners were rendering oddly. When I first tested the update I guessed it might break other WM's but after testing it on XMonad and it not breaking I thought it was fine.

If you can manually build picom, can you please try removing 1.2.3 and manually building 1.2.2 https://github.com/allusive-dev/picom-allusive/releases/tag/1.2.2

allusive-dev commented 10 months ago

Forget what I just sent. Update to 1.2.6 @nousername33 Should hopefully fix the issue. Let me know if not.

ixion396 commented 10 months ago

Unfortunately it did not.

allusive-dev commented 10 months ago

Unfortunately it did not.

@nousername33 Can you send images or videos of the issue? Also after what update did the issue start occuring?

amkillam commented 10 months ago

Experiencing this issue in bspwm as well.

image

amkillam commented 10 months ago

Only installed this last night, so unsure when it started. Otherwise, really awesome fork! Picom animations are super smooth.

allusive-dev commented 10 months ago

This issue is related to yshui/picom-#808

allusive-dev commented 10 months ago

I'll start work on this soon and come back with a release.

amkillam commented 10 months ago

@allusive-dev if it helps, I had this occur in every other picom fork as well, except for picom-ibhagwan, which was recently removed from the aur, hence the switch lol.

allusive-dev commented 10 months ago

@allusive-dev if it helps, I had this occur in every other picom fork as well, except for picom-ibhagwan, which was recently removed from the aur, hence the switch lol.

Makes sense because the PR that was supposed to fix the issue was never merged into yshui/picom lol

amkillam commented 10 months ago

@allusive-dev if it helps, I had this occur in every other picom fork as well, except for picom-ibhagwan, which was recently removed from the aur, hence the switch lol.

Makes sense because the PR that was supposed to fix the issue was never merged into yshui/picom lol

Ah that makes a lot of sense lol.

https://github.com/yshui/picom/commit/60eb00ce1b52aee46d343481d0530d5013ab850b

Here's the diff of the changes in that branch

allusive-dev commented 10 months ago

@nousername33 @amkillam

I am releasing update 1.2.9, please let me know if it resolves the issues.

(Now on the AUR)

amkillam commented 10 months ago

@allusive-dev Unfortunately the issue is still present, though I appreciate and am impressed by your very fast response time!

allusive-dev commented 10 months ago

@nousername33 I just installed i3 and tested with 1.2.9 and there are no issues with black corners anymore. I tested with kitty as you said it was affected but it is not now.

allusive-dev commented 10 months ago

@amkillam

Just had an idea. Can you try putting this in your config along with update 1.2.9 and please let me know if it works.

wm-support = "awesome"

If adding that option also does not fix the issue, please send your picom.conf

allusive-dev commented 10 months ago

@amkillam

I just got bspwm setup. And ran picom with my config and there is absolutely no issues with picom.

The last thing I can assume is this is either a hardware issue or a problem with your configuration.

I will attach my configuration, please use it and let me know if the issue is still present. (rename the file to picom.conf before using)

picom.conf.txt

amkillam commented 10 months ago

@allusive-dev I just switched to linux-git, for unrelated reasons. Inexplicably, the corners are now working! I'm unsure why they're working now despite quite a few reboots with them not working since the changes you pushed, but I'm content regardless lol. Good work! All seems to be working perfectly now.

allusive-dev commented 10 months ago

@allusive-dev I just switched to linux-git, for unrelated reasons. Inexplicably, the corners are now working! I'm unsure why they're working now despite quite a few reboots with them not working since the changes you pushed, but I'm content regardless lol. Good work! All seems to be working perfectly now.

I'm very happy to hear that it is working for you. Please make sure to let me know if anything else comes up.

@nousername33 I am going to close this issue now under the assumption the issue is solved since I tested it. If this is not the case please feel free to comment again on here and I will re-open it.