allusive-dev / compfy

A Compositor for X11 based on Picom. No Longer Maintained in favor of Picom v12!
198 stars 24 forks source link

[IMPLEMENTED] Rules For Rounded Corners #5

Closed thecodsman closed 1 year ago

thecodsman commented 1 year ago

how do you add rules for rounded corners (like opacity rule but for rounded corners) and if it is currently not possible could you add it

allusive-dev commented 1 year ago
rounded-corners-exclude = [
  "class_g = 'Alacritty'",
];
allusive-dev commented 1 year ago

I have also just now updated the wiki with this information.

thecodsman commented 1 year ago
rounded-corners-exclude = [
  "class_g = 'Alacritty'",
];

thats excluding rounded corners entirely from that thing but what im saying is that you can change how rounded the corners are for a specific thing like in regular picom you can do

corner-radius-rule = [
 "10:class_g = 'dmenu'"
]

and dmenu would have a corner radius of 10 (even if you set your corner radius to something else)

allusive-dev commented 1 year ago

Oh. I see. I don't think that is a feature of this picom fork but you could try that code snippet you sent. Otherwise I can try to integrate this feature.

thecodsman commented 1 year ago

I do have it in my config and it doesnt work (ive also tried corner-radius-rules rounded-corners-rule and rounded-corners-rules)

allusive-dev commented 1 year ago

Alright i will take a look at whether I can integrate it sometime today.

thecodsman commented 1 year ago

also could you add rules for animations (where you could change things like not only the animation type but also the mass and stuff) also animation exclude

allusive-dev commented 1 year ago

also could you add rules for animations (where you could change things like not only the animation type but also the mass and stuff) also animation exclude

I can have a go at animation exclude but have you read the wiki concerning the other stuff?

thecodsman commented 1 year ago

I dont see anything about animation rules but I might be dumb

thecodsman commented 1 year ago

it seems like anything with multiple options doesnt have a rule list but it would be cool if they did ;)

allusive-dev commented 1 year ago

I can try working on animation rules but i need a bit more explanation on what you are looking for. Do you have discord/matrix?

Contacts

thecodsman commented 1 year ago

like you could do

animation-rules:
[
 "mass=10, dampening=20, animation-for-window-open='slide-up':class_g = 'dmenu'"
 "mass=0, dampening=0, animation-for-window-open='slide-left', animation-for-window-close='slide-right':class_g = 'firefox'"
]

so each option would be seperated by a comma and then you put a colon and the condition I hope that explains more of what I want

allusive-dev commented 1 year ago

Hm. Well you see, that is very complicated and something I definitely cannot do. Most I can maybe do is make a ruleset for windows that are excluded from being animated. Sorry.

thecodsman commented 1 year ago

it fine, it wasnt a feature I wanted that bad anyways. animation exclude is more what I want

allusive-dev commented 1 year ago

I hate to like have an ego but I actually just got animation-exclude to work first try.

Just to check would you like me to make multiple exclude list for each type of animation? e.g. open, unmap

Or just for both/all animation types?

thecodsman commented 1 year ago

if you can it it would be cool to have separate exclude list for each type but if you cant its not a big deal.

(also dont forget about the corner-radius-rule)

thecodsman commented 1 year ago

sorry I keep giving you more features to add lol

allusive-dev commented 1 year ago

Hm yeah corner-radius-rule should be fun, I'll see what I can do.

I should be able to do 2 different exclude lists.

sorry I keep giving you more features to add lol

No problem, gives me something to do when I am not working.

allusive-dev commented 1 year ago

Good news i got both the animation exclude rule sets working but I may not be able to do the corner-radius-rule sadly due to the way it is integrated. I'll let you know if i make progress on it in the future.

thecodsman commented 1 year ago

ok cool

allusive-dev commented 1 year ago

You wanted it. I did it. @thecodsman

In all honesty I actually got it to work and i am insanely happy.

Check the documentation for more info!

thecodsman commented 1 year ago

lets goooooooooo thank you

thecodsman commented 1 year ago

@allusive-dev I tested it and it doesnt work on dwm :( because I tried it on i3 and it worked. Also its worth noting that in regular picom the corner-radius-rule worked for me in dwm

thecodsman commented 1 year ago

nvm it just started working suddenly

allusive-dev commented 1 year ago

nvm it just started working suddenly

Awesome, I am glad to hear