r1415 breaks Windows ninja builds due to excessively long path names

[GoogleCodeExporter]

r1415 causes the Windows ninja build to break since it now generates rsp files 
with names like:

cloud_policy_backend_header_compile_target_src_chrome_app_policy_cloud_policy_co
degen_gyp_cloud_policy_backend_header_compile_target_genproto.pyproto_chrome_bro
wser_policy_proto_device_management_backend_pb2_py.rsp

This file name is 214 characters. Windows has a 260 character MAX_PATH, so 
depending upon the CWD in which you're building, ninja is unable to create the 
rsp file:

WriteFile(cloud_policy_backend_header_compile_target_src_chrome_app_policy_cloud
_policy_codegen_gyp_cloud_policy_backend_header_compile_target_genproto.pyproto_
chrome_browser_policy_proto_device_management_backend_pb2_py.rsp): Unable to 
create file. No such file or directory

occurred for me with a CWD of C:\cygwin\home\buildbot\desktop\src\out\Debug

Original issue reported on code.google.com by jaysoff...@gmail.com on 22 Jun 2012 at 9:27

[GoogleCodeExporter]

steveblock, can you take a look? If I remember correctly, r1415 wasn't critical 
for anything; do you think we should revert it until this is resolved as it 
blocks some people from work?

Original comment by thakis@chromium.org on 22 Jun 2012 at 9:29

[GoogleCodeExporter]

scottmg landed a workaround in r1421 which uses action_name/rule_name + '_' + 
md5(qualified_target).

I'll look into omitting the hash suffix if the action/rule name is already 
unique.

Original comment by stevebl...@chromium.org on 25 Jun 2012 at 11:40

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by mseaborn@chromium.org on 12 Sep 2012 at 11:52

[GoogleCodeExporter]

steveblock's no longer on chromium.

Original comment by thakis@chromium.org on 13 Sep 2012 at 12:23

[GoogleCodeExporter]

Original comment by stevebl...@chromium.org on 19 Nov 2012 at 3:22