search

allyfern72 / pe

0 stars 0 forks source link

Price of dish is not accurate for large numbers #2

Open allyfern72 opened 2 years ago

allyfern72 commented 2 years ago

When inputting a very large integer, digits after the 18th place become 0.

image.png

Could possibly consider having a max price cap on dishes.

soc-se-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

These two issues are actually the same thing.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Price of a dish can be infinity

When I edit a dish, i can make the dish infinity when i input "1e10000"

image.png

[original: nus-cs2113-AY2122S2/pe-interim#863] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Teams believes that this is a form of extreme and unusual input provided by user.

In such case, programme continues to work as per normal, without any crashes or severe unusability.

Duplicate issues can be fixed from the same place in the code.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]