Implement PWA for mobile experience

jasonpaulso commented 4 weeks ago

Closes #205 (hopefully...)

adds and initializes serviceworker gem
adds tag helpers for head
implements tag helpers in head
adds PWA related tags and scripts for splash screen
adds manifest.json
adds new icons for PWA
adds <% content_for :title ... %> to home and settings views

jasonpaulso commented 4 weeks ago

@krschacht what can you tell me about the The section #messages was able to move down so it was not at the bottom. error?

krschacht commented 4 weeks ago

It’s a flaky test that has to do with parallel test runners. Just rerun CI a couple times and it should pass.

In my branch I have another attempted fix to increase reliability of it so no need to investigate.

On Fri, Apr 19, 2024 at 7:12 PM Jason Schulz @.***> wrote:

@krschacht https://github.com/krschacht what can you tell me about the The section #messages was able to move down so it was not at the bottom. error?

— Reply to this email directly, view it on GitHub https://github.com/allyourbot/hostedgpt/pull/282#issuecomment-2067514898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIR5M6VGUIGQHTHJWLY2DY6HFKXAVCNFSM6AAAAABGPN5DWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGUYTIOBZHA . You are receiving this because you were mentioned.Message ID: @.***>

krschacht commented 3 weeks ago

@jasonpaulso I really appreciate how knowledgable you are about this PWA stuff! I just caught up on your comments and it sounds like you have an additional change to make to the serviceworker? I won't merge this in quite yet.

I'm about to update the asset_path() change that I made simply to undo it and clean up the old files. I'll push that small commit to this branch shortly.

Aside from those two things, there are two items on my "Future PWA improvements" list that I want to call your attention to. What do you think of these two?

https://github.com/allyourbot/hostedgpt/issues/298

The first on that list is about the overall icon seeming a bit tight (favicon is good, I just mean app icon). What's your opinion on that? This is admittedly a bit nitpicky so maybe it's just me, and plus, I don't know how easy that is to fix.

The second is probably a bug with the ios-pwa-splash unpkg link? Again, I don't know how hard that might be to fix.

I'm okay leaving both those issues in this PR and we can fix going forward, but chime in and let me know what you think because if either is easy it may be worth fixing now.

jasonpaulso commented 3 weeks ago

I'd say we can just remove the service worker file and gem for now. There isn't much use for it yet, considering the app has no push notifications and doesn't really work without network connection. As far as the rest, I cannot repro the iPad issue—on my iPad and simulator the splash screen dismisses too quickly to get a look at it. There are other options we can look into instead of ios-pwa-splash though. Regarding the icon, I agree that it's not so comfortable on the home screen or dock. I can make some quick changes to it and we can see how it feels.

krschacht commented 3 weeks ago

Merging in! I love that it's actually usable on mobile now. :) It was pretty painful to use the app before with the browser toolbar present.

allyourbot / hostedgpt

Implement PWA for mobile experience #282