search

allyourbot / hostedgpt

An open version of ChatGPT you can host anywhere or run locally.
MIT License
193 stars 75 forks source link

Conditionalizing attachment icon in composer is broken #319

Closed krschacht closed 1 week ago

krschacht commented 2 weeks ago

GPT-3.5 is currently the one model that does not support evaluating images. The composer is conditionalized to hide that, based on the model, and you can see it's kind of working since the placeholder text is slid to the left but the icon is not disappearing:

image
krschacht commented 2 weeks ago

@jasonpaulso Maybe this is related to recent CSS reworking? Tagging you just in case you already know. I'll eventually get around to investigating this as well.

jasonpaulso commented 2 weeks ago

I’m happy to look into this. Can you give me repro steps?On May 2, 2024, at 5:22 PM, Keith Schacht @.***> wrote: @jasonpaulso Maybe this is related to recent CSS reworking? Tagging you just in case you already know. I'll eventually get around to investigating this as well.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

krschacht commented 2 weeks ago

Yep, switch the model to GPT-4 and look at the composer (where you enter chat messages), there should be an attachment icon on the left. But then switch the model to GPT-3.5 and look at the composer again — the attachment icon should be hidden.

jasonpaulso commented 2 weeks ago

I couldn’t identify a point where my changes may have caused this regression, but I have PRd a potential fix.

On May 3, 2024, at 9:20 AM, Keith Schacht @.***> wrote:

Yep, switch the model to GPT-4 and look at the composer (where you enter chat messages), there should be an attachment icon on the left. But then switch the model to GPT-3.5 and look at the composer again — the attachment icon should be hidden.

— Reply to this email directly, view it on GitHub https://github.com/allyourbot/hostedgpt/issues/319#issuecomment-2093007874, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACT5ZUW5TY7U4AW5BI42MBLZAOFJ5AVCNFSM6AAAAABHEOWJUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGAYDOOBXGQ. You are receiving this because you were mentioned.