Au to disable In page if feature flag is false - Githubissues

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma

Other

6 stars 9 forks source link

Au to disable In page if feature flag is false #103

Closed Francois-Gomis closed 1 year ago

Francois-Gomis commented 1 year ago

Reason for change

Disable in_page if feature flag is false Linear task

Code changes

Add a disableInPage function at save if feature tag is false

How to test

Enable in page with a merchant with feature tag - remove feature and save configuration In page must be disabled

Checklist for authors and reviewers

[x] The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
[x] The PR implements the changes asked in the referenced task / issue
[x] The automated tests are compliant with the testing strategy
[x] The tests are relevant, and cover the corner/error cases, not only the happy path

Non applicable

[ ] You understand the impact of this PR on existing code/features
[ ] The changes include adequate logging and Datadog traces
[ ] Documentation is updated (API, developer documentation, ADR, Notion...)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication