fix: change selectPaymentMethod name and call default method

[Francois-Gomis]

Reason for change

Bug on checkout

Linear task

Code changes

How to test

Select another payment method in first and after select Alma. Alma payment method doesn't work fine - no call to set-payment-method in network and no open description.

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

• [ ] The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
• [ ] The PR implements the changes asked in the referenced task / issue
• [ ] The automated tests are compliant with the testing strategy
• [ ] The tests are relevant, and cover the corner/error cases, not only the happy path
• [ ] You understand the impact of this PR on existing code/features
• [ ] The changes include adequate logging and Datadog traces
• [ ] Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[danielgoodwin97]

For the record, this is the goofiest possible way you could've fixed this.

When overwriting a method and you still want it to perform it's previous action, call this._super(); at the top of the method, then add your additional code.

This could have been fixed in one line:

            selectPaymentMethod : function() {
                this._super();
                self.unMountInPage();
                const currentPaymentMethod = self.checkedPaymentMethod();
                if( self.lastSelectedPlan()[currentPaymentMethod].inPageAllowed) {
                    self.selectInstallments(self.lastSelectedPlan()[currentPaymentMethod]);
                }
                return true;
            },