search

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma
Other
6 stars 9 forks source link

Code generation failed with php 7.3 and v4.1.0 #114

Closed lapriqua closed 2 months ago

lapriqua commented 10 months ago

Hi,

Seems the class \Alma\MonthlyPayments\Controller\Payment\Eligibility is not compatible with php version previous 7.4. The fact that the $logger property is typed break this compatibility.

KevinOxwork commented 7 months ago

Hi, Do you think that if we do this, it will work ?

image

lapriqua commented 7 months ago

Hi,

Yes, it should work. That's the only thing that break the compatibility with php 7.3