Gather cart data from pnx and deferred payments - Githubissues

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma

Other

6 stars 9 forks source link

Gather cart data from pnx and deferred payments #151

Closed joyet-simon closed 3 months ago

joyet-simon commented 3 months ago

Reason for change

Code changes

Juste delete the "if" condition which used to verify if the payment methods is > 5 to add cart data in the payment object. And update unit tests

How to test

As a reviewer, you are encouraged to test the PR locally. You can run unit tests.

Checklist for authors and reviewers

[x] The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
[x] The PR implements the changes asked in the referenced task / issue
[x] The automated tests are compliant with the testing strategy
[x] The tests are relevant, and cover the corner/error cases, not only the happy path
[x] You understand the impact of this PR on existing code/features

Non applicable

[ ] The changes include adequate logging and Datadog traces
[ ] Documentation is updated (API, developer documentation, ADR, Notion...)

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 3 months ago

⏳E2E tests are currently running. ➡️ You can follow their progression here.

github-actions[bot] commented 3 months ago

❌ E2E tests have failed. ➡️ You can find the results here.