[DEVX] Add a task to install pre-commits

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma

Other

6 stars 9 forks source link

[DEVX] Add a task to install pre-commits #160

Closed carine-bonnafous closed 4 months ago

carine-bonnafous commented 4 months ago

Reason for change

Add task pre-commit:install to ease installation of pre-commits (as the hook commit-msg needs to be installed explicitely)

github-actions[bot] commented 4 months ago

⏳E2E tests are currently running. ➡️ You can follow their progression here.

github-actions[bot] commented 4 months ago

❌ E2E tests have failed. ➡️ You can find the results here.

github-actions[bot] commented 4 months ago

⏳E2E tests are currently running. ➡️ You can follow their progression here.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

❌ E2E tests have failed. ➡️ You can find the results here.

remi-zuffinetti commented 4 months ago

Is it okay that it's not passing yet?

carine-bonnafous commented 4 months ago

Is it okay that it's not passing yet?

@remi-zuffinetti Yes, the linter has been introduced recently, some work is needed to make the code compliant with it. (@Francois-Gomis is aware of it :) ) (And then we will set the check as required)