alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma
Other
6 stars 9 forks source link

Fix configuration iframe parameters and insurance parent product price #161

Closed Francois-Gomis closed 4 months ago

Francois-Gomis commented 4 months ago

Reason for change

https://linear.app/almapay/issue/ECOM-1709/[🧩-ac]-update-details-in-ac-for-the-cart-item-level-release https://linear.app/almapay/issue/ECOM-1715/[🧩-ac]-fix-send-price-with-promotion-and-ttc-to-neat

Code changes

Remove params in backend iframe url and add a new function. Change parent_price in data, in widget and in get contract details call. Add parent_price in InsuranceConfig construct class

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

Non applicable

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint