Add signature verification on ipn - Githubissues

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma

Other

6 stars 9 forks source link

Add signature verification on ipn #191

Closed Francois-Gomis closed 2 months ago

Francois-Gomis commented 2 months ago

Reason for change

[Linear task](https://linear.app/almapay/issue/ECOM-xxx/)

Code changes

Add signature validation on IPN controller

How to test

Test with a QA instance for real signature. With the same payment test with postman without signature and with a bad signature

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

[X] The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
[X] The PR implements the changes asked in the referenced task / issue
[X] The automated tests are compliant with the testing strategy
[X] The tests are relevant, and cover the corner/error cases, not only the happy path
[X] You understand the impact of this PR on existing code/features
[X] The changes include adequate logging and Datadog traces

Non applicable

[ ] Documentation is updated (API, developer documentation, ADR, Notion...)

github-actions[bot] commented 2 months ago

⏳E2E tests are currently running. ➡️ You can follow their progression here.

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
13.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

❌ E2E tests have failed. ➡️ You can find the results here.