Add rest in send collect and change trigger - Githubissues

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma

Other

6 stars 9 forks source link

Add rest in send collect and change trigger #213

Closed Francois-Gomis closed 1 week ago

Francois-Gomis commented 1 week ago

Reason for change

[Linear task](https://linear.app/almapay/issue/ECOM-xxx/)

Code changes

Add rest to url and change trigger from after save to loadconfig

How to test

With a new instance, save an api key and check metabase

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

[ ] The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
[ ] The PR implements the changes asked in the referenced task / issue
[ ] The automated tests are compliant with the testing strategy
[ ] The tests are relevant, and cover the corner/error cases, not only the happy path
[ ] You understand the impact of this PR on existing code/features
[ ] The changes include adequate logging and Datadog traces
[ ] Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 1 week ago

⏳E2E tests are currently running. ➡️ You can follow their progression here.

github-actions[bot] commented 1 week ago

❌ E2E tests have failed. ➡️ You can find the results here.