search

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma
Other
6 stars 9 forks source link

Compatible with Monolog\Logger #43

Closed Amadeco closed 2 years ago

Amadeco commented 2 years ago

Missing a param for the parent calling.

Throw a fatal error :

PHP Fatal error: Declaration of Alma\MonthlyPayments\Helpers\Logger::addRecord($level, $message, array $context = []): bool must be compatible with Monolog\Logger::addRecord(int $level, string $message, array $context = [], ?Monolog\DateTimeImmutable $datetime = null): bool in /vendor/alma/alma-monthlypayments-magento2/Helpers/Logger.php on line 74

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sebfie commented 2 years ago

Hello, it will be great to merge it :p

Francois-Gomis commented 2 years ago

Thanks for your Pull request , we will add this fix in our next magento compatibility release (2.4.4) .