search

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma
Other
6 stars 9 forks source link

Alma is not compatible with magento 2.4.4 #52

Closed amine-y closed 2 years ago

amine-y commented 2 years ago

I'm trying to upgrade to magento 2.4.4 and this error came up I'm using alma 2.6.0

Warning: Declaration of Alma\MonthlyPayments\Helpers\Logger::addRecord($level, $message, array $context = Array): bool should be compatible with Monolog\Logger::addRecord(int $level, string $message, array $context = Array, ?Monolog\DateTimeImmutable $datetime = NULL): bool in vendor/alma/alma-monthlypayments-magento2/Helpers/Logger.php on line 74
webpar commented 2 years ago

Hello,

Until an official fix is provided, in order to fix this issue, you'll need to update the file vendor/alma/alma-monthlypayments-magento2/Helpers/Logger.php and replace addRecord function declaration by : public function addRecord(int $level, string $message, array $context = [], \Monolog\DateTimeImmutable $datetime = null): bool

amine-y commented 2 years ago

@webpar Thanks that what i already did

Francois-Gomis commented 2 years ago

Hello, Thanks for your issue. I prepare fix for the next version.

sebfie commented 2 years ago

Hello, I do not see it on master branch

Francois-Gomis commented 2 years ago

Hi, new version is not yet published.

sebfie commented 2 years ago

Can you maybe just push on master :p