search

alma / alma-monthlypayments-magento2

Magento 2 Payment Gateway integration for Alma
Other
6 stars 9 forks source link

fix:getProduct from registry updated #64

Closed thacac closed 2 years ago

thacac commented 2 years ago

Fixes #63 CRITICAL

[2022-09-22T11:47:35.244653+00:00] main.CRITICAL: Error: Call to a member function getId() on null in /var/www/xxxxx/vendor/alma/alma-monthlypayments-magento2/Block/Catalog/Product/View.php:96 Stack trace:

0 /var/www/xxx/vendor/alma/alma-monthlypayments-magento2/Block/Catalog/Product/View.php(85): Alma\MonthlyPayments\Block\Catalog\Product\View->getProduct()

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Francois-Gomis commented 2 years ago

Hi, thanks for your Pull request. We have changed this code in version 3.0.0. View class extends now Magento\Catalog\Block\Product\View and getProduct method is now a core function.

Normally this fix solves this issue. Thanks