search

almaforrer / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

CSS is clean and succinct #3

Open ad3429 opened 6 years ago

ad3429 commented 6 years ago

https://github.com/almaforrer/prj-rev-bwfs-tea-cozy/blob/master/TeaCosy/resources/css/style.css#L1-L195

Your CSS is short, clean and succinct -- make sure to keep it up! Also, nice job commenting your main stylings which is something learners often forget to do.

almaforrer commented 6 years ago

thank you very much for your very nice feedback! But don't you think I had a problem with centering elements? Most of the time I just did it with approximate calculs or just by watching the spaces btw the divs! Isn't it .. bad? Because of that I felt a bit like I failed this exercise -even if it seems that it s maybe not as bad as I thought! thank you very much! Alma

almaforrer commented 6 years ago

For example in the css, the 3rd LOCATION box ".boxoakdale" didn't followed the flex display as the two first boxes did, and I couldn't understand why.. So I just adjusted it manually. Do you think you could enlight me on that point? Thank you!