search

almartin82 / mapvizieR

visualizations and reports for the NWEA MAP assessment in R
Other
17 stars 6 forks source link

Change cgp_calc return values #254

Open almartin82 opened 8 years ago

almartin82 commented 8 years ago

Right now it returns both targets and results in a named list. I output should be controlled in a parameter

almartin82 commented 8 years ago

I'm not sure this is a good idea anymore. It would require a major refactor on all the calls to cgp_calc. If we want to make the interface to cgp_calc more predictable and pipeable (which is a good goal), let's simply write specific wrappers around cgp calc that call the function as-is and extract the relevant object before returning it.