search

almartin82 / mapvizieR

visualizations and reports for the NWEA MAP assessment in R
Other
17 stars 6 forks source link

don't ever use `mapvizieR::` in internal function calls #300

Closed almartin82 closed 7 years ago

almartin82 commented 8 years ago

it will work in dev but not in production if the function is not exported.

when I was implementing #294 I started seeing some issues where method dispatch on some of the mapvizieR objects was breaking down. as a stopgap, I introduced some code like this. but in production, because the growth method on that object is not exported in the mapvizieR namespace, it can't find that mapvizier.summary_cdf() function, even though I am being explicit.

TIL: solve the problems with method dispatch (here on summary()), don't bring in work-arounds.

almartin82 commented 7 years ago

now I just need to find all of these, because we have the verb methods.