search

almartin82 / mapvizieR

visualizations and reports for the NWEA MAP assessment in R
Other
17 stars 6 forks source link

groups #305

Closed almartin82 closed 7 years ago

almartin82 commented 8 years ago

so I closed an older PR on this branch (#297), but re-opening, because there's a lot of important code here that needs to get back to master.

to solve #294, we need to implement #304 - @chrishaid let's keep this PR open and try to get this done by the end of the week!

codecov-io commented 8 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e60da03). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #305   +/-   ##
=========================================
  Coverage          ?   91.42%           
=========================================
  Files             ?       60           
  Lines             ?     7288           
  Branches          ?        0           
=========================================
  Hits              ?     6663           
  Misses            ?      625           
  Partials          ?        0
Impacted Files Coverage Δ
R/growth_status_class.R 0% <ø> (ø)
R/cgp_target_plot.R 0% <ø> (ø)
R/read_cdf.R 0% <ø> (ø)
R/schambach_figure.R 100% <100%> (ø)
R/roster_prep.R 100% <100%> (ø)
R/college_plots.R 100% <100%> (ø)
R/student_npr_two_term_plot.R 93.81% <100%> (ø)
R/growth_df_prep.R 99.43% <100%> (ø)
R/strand_summary_plot.R 82.43% <100%> (ø)
R/fuzz_test.R 80% <100%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e60da03...cdc7e9f. Read the comment docs.

chrishaid commented 8 years ago

Do you want me to merge this now, or to wait?

almartin82 commented 8 years ago

wait, it's not ready yet :/

On Mon, Aug 1, 2016 at 11:28 AM, Chris Haid notifications@github.com wrote:

Do you want me to merge this now, or to wait?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/almartin82/mapvizieR/pull/305#issuecomment-236614915, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvvNzhsAJglZoMuXXCaoMbDp6sQtmqxks5qbhCjgaJpZM4JZl6g .

almartin82 commented 7 years ago

@chrishaid this is getting crazy - this branch is SO far out ahead. I will try to prioritize the dplyr wrappers so that we can bring this baby back to master. would love any help you can provide...

almartin82 commented 7 years ago

@chrishaid the crucial change is here

chrishaid commented 7 years ago

This pull request isnt mergable. It has conflicts (see above). Plus tests are failing.

almartin82 commented 7 years ago

@chrishaid this is passing wercker